Update generate_rust_analyzer.py #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro field rust-analyzer now doesn't complain about unresolved imports anymore inside of the rust/macros crate. Upstream PR which added the field: rust-lang/rust-analyzer#9752 Signed-off-by: Boris-Chengbiao Zhou <[email protected]>
Update the script to account for the new way helpers are handled since commit 7324a8. Signed-off-by: Boris-Chengbiao Zhou <[email protected]>
nbdd0121
approved these changes
Aug 26, 2021
bjorn3
approved these changes
Aug 26, 2021
|
Thanks! A small note: changes should be in different commits, i.e. the change of default parameters should be on a different commit. It is OK now because we still rebase for upstreaming, but later on we will not be able to take commits that mix them! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is_proc_macrofield in the generated rust-project.json. rust-analyzer now properly resolves theuse use proc_macro::TokenStreamimport. I've also taken the liberty to slightly refactor the script a bit to reduce duplication.