Skip to content

Add overflow_assert! #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ojeda opened this issue Apr 25, 2025 · 1 comment
Open

Add overflow_assert! #1159

ojeda opened this issue Apr 25, 2025 · 1 comment
Labels
easy Expected to be an easy issue to resolve. good first issue Good for newcomers • lib Related to the `rust/` library. medium Expected to be an issue of medium difficulty to resolve.

Comments

@ojeda
Copy link
Member

ojeda commented Apr 25, 2025

See https://lore.kernel.org/rust-for-linux/CANiq72=VbcYroRz1EcbzHqFHwaHLewK+DvK756ropM16pDdMuw@mail.gmail.com/

The name mimics other {kind}_assert!s like debug_assert!, as well as core's ub-checks one (assert_unsafe_precondition!).

Please double check if there are already asserts out there (or perhaps even new ones) that could make use of it, and transform (or add) them in a second patch etc.

See #1162 as well.


This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag, and a Link: tag to this issue. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.

@ojeda ojeda added easy Expected to be an easy issue to resolve. good first issue Good for newcomers medium Expected to be an issue of medium difficulty to resolve. • lib Related to the `rust/` library. labels Apr 25, 2025
@antonio-hickey
Copy link

I'll take this on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Expected to be an easy issue to resolve. good first issue Good for newcomers • lib Related to the `rust/` library. medium Expected to be an issue of medium difficulty to resolve.
Development

No branches or pull requests

2 participants