Improve math_builder_methods.
#279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently produces silly verbose code like this:
and relies on constant folding to eliminate most of the code.
This commit changes the macro to produce code like this:
and float ops are even shorter, because they don't need a u128 check and are now done with a new, separate macro:
The generated code is much shorter:
cargo expand's length has reduced from 34,636 lines to 26,356 lines, a 24% reduction.The original code is also a little shorter.
arg_vecsis gone because it isn't needed. The asserts are gone because they were very low value. There is now a tiny bit of code duplication, but it's trivial and not worth trying to avoid.