Initiate the project #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch implements the basic framework of binding the RCL library to the JavaScript interface, meanwhile brings out the timer object and with an example of it. The project is using eslint (JavaScript) and cpplint (c/c++) to check the static syntax. Hopefully, unit tests will be added later. And the buildbot is running on travis-ci with docker srevice.
|
Hi @minggangw, could you actually create a PR against |
|
FYI, I just created develop branch and made it as default |
|
Got it, thanks! |
|
Close this pr as I have created another #2 , which is based on the develop branch. |
kenny-y
pushed a commit
to kenny-y/rclnodejs
that referenced
this pull request
Jun 22, 2017
FFI string assign
This was referenced Oct 5, 2021
minggangw
pushed a commit
that referenced
this pull request
Oct 21, 2021
#814) Public API Changes ClientGoalHandler (client_goal_handler.js, action_client.d.ts) deprecated accepting getter added convenience methods: isAccepting(), isExecuting(), isCanceling(), isSucceeded(), isCanceled(), isAborted(). These methods are not essential. Thus will leave it to the reviewer's discretion of whether they stay or go. The same for Initiate the project #1 above. status property is now properly updated with the goal lifecycle state codes, see ActionInterfaces.GoalStatus for codes getResult() now returns a ActionResult. Previously it returned an internal message with structure {status: number, result: ActionResult<T>}. ClientGoalHandle feedback function now only receives a ActionFeedback<T> argument. Previously ActionFallback<T> function was receiving an internal msg with structure {goal_id: UUID, feedback: ActionFeedback}`. Description A bug was submitted where ClientGoalHandler.getResult() was returning an internal message that did not conform to the TypeScript declarations. Additionally the ClientGoalHandler.status was never being updated and always return UNKNOWN. Lastly while fixing the getResult() bug it was discovered that the feedbackCallback function was being sent an internal message and not the expected ActionFeedback<T> type. This fix resolves all 3 issues. I added beforeSetResult(result) method to Deferred.js class. This is used by the ActionClient _getResult(resultMsg) method to update the ClientGoalHandler.status and to return only the msg.result property of type ActionResult<t>. Updated all action related tests and examples. Fixed several prettier/lint issues. Fix #813
minggangw
pushed a commit
that referenced
this pull request
Nov 2, 2021
#814) Public API Changes ClientGoalHandler (client_goal_handler.js, action_client.d.ts) deprecated accepting getter added convenience methods: isAccepting(), isExecuting(), isCanceling(), isSucceeded(), isCanceled(), isAborted(). These methods are not essential. Thus will leave it to the reviewer's discretion of whether they stay or go. The same for Initiate the project #1 above. status property is now properly updated with the goal lifecycle state codes, see ActionInterfaces.GoalStatus for codes getResult() now returns a ActionResult. Previously it returned an internal message with structure {status: number, result: ActionResult<T>}. ClientGoalHandle feedback function now only receives a ActionFeedback<T> argument. Previously ActionFallback<T> function was receiving an internal msg with structure {goal_id: UUID, feedback: ActionFeedback}`. Description A bug was submitted where ClientGoalHandler.getResult() was returning an internal message that did not conform to the TypeScript declarations. Additionally the ClientGoalHandler.status was never being updated and always return UNKNOWN. Lastly while fixing the getResult() bug it was discovered that the feedbackCallback function was being sent an internal message and not the expected ActionFeedback<T> type. This fix resolves all 3 issues. I added beforeSetResult(result) method to Deferred.js class. This is used by the ActionClient _getResult(resultMsg) method to update the ClientGoalHandler.status and to return only the msg.result property of type ActionResult<t>. Updated all action related tests and examples. Fixed several prettier/lint issues. Fix #813
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch implements the basic framework of binding the RCL library
to the JavaScript interface, meanwhile brings out the timer object and
with an example of it.
The project is using eslint (JavaScript) and cpplint (c/c++) to check
the static syntax. Hopefully, unit tests will be added later. And the
buildbot is running on travis-ci with docker srevice.