Added attributes support

[kukulich]

• Array support for arguments
• Compile arguments
• getClass()
• Tests
• Adapters - waiting for PHP 8.0.12 ( Make Reflection(Attribute|Enum|EnumBackedCase) non-final php/php-src#7520 )

[kukulich]

ReflectionAttribute is final so I don't know how to implement the adapter: https://www.php.net/manual/en/class.reflectionattribute.php

[asgrim]

ReflectionAttribute is final so I don't know how to implement the adapter: https://www.php.net/manual/en/class.reflectionattribute.php

I guess for now we just can't have an adapter for ReflectionAttribute, not a lot we can do about it I think :/

[kukulich]

@ondrejmirtes is trying to persuade PHP developers to remove the final.

[ondrejmirtes]

I¨ve asked in Room 11: https://chat.stackoverflow.com/transcript/message/53093466#53093466

I'll open a bug if no one responds there.

[Ocramius]

I think opening a bug would indeed be the best way forward: room 11 is full of helpful people, but if a change comes exclusively from there, it will be frown upon by internals

[ondrejmirtes]

Alright, let's see: https://bugs.php.net/bug.php?id=81474

[Ocramius]

BTW, we could decide to merge without adapter support, and split that part of the problem out, for now

[kukulich]

Yes, I need to rebase it now and will send it to review.

[kukulich]

@Ocramius This is ready to review. I would add getClass() later.

[donquixote]

A quick observation about this effort:

• ReflectionAttribute in the PHPStan fork, master branch, does support PHP < 8, but it does not support named arguments for attributes.
• This PR does appear to support named arguments, but is starting from a version of BetterReflection that requires PHP 8+.

I was hoping for a tool that would bring attributes to PHP < 8.

[andrew-demb]

@donquixote here it is https://github.com/spiral/attributes

[Ocramius]

@kukulich meanwhile, php:8.0.12 is available since yesterday \o/

[kukulich]

@Ocramius Yes, but even 24266a0 does not help to run the actions. We have to wait...

[Ocramius]

Looks like 8.0.12 finally made it into the PPA:

• https://launchpadlibrarian.net/565073627/php8.0_8.0.12-1+ubuntu21.04.1+deb.sury.org+1_source.changes

Therefore, https://github.com/shivammathur/setup-php is also picking it up now :)

[Ocramius]

One failure left:

Time: 00:25.012, Memory: 1.94 GB

There was 1 failure:

1) Roave\BetterReflectionTest\Reflection\Adapter\ReflectionAttributeTest::testCoreReflectionMethods with data set "__toString" ('__toString')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Roave\BetterReflection\Reflection\Adapter\ReflectionAttribute'
+'ReflectionAttribute'

/home/runner/work/BetterReflection/BetterReflection/test/unit/Reflection/Adapter/ReflectionAttributeTest.php:38

FAILURES!
Tests: 11466, Assertions: 69307, Failures: 1, Skipped: 6.
Error: Process completed with exit code 1.

[Ocramius]

🚢