use a dynamic bytes swizzle for swizzle_to_front
#331
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207
As the comments say, unfortunately, this leads to pretty suboptimal code unless the std library is compiled with the required target feature, and the default x86_64 target (except for macos) is not compiled with the required target feature.
See godbolt showing assembly for: default x86_64 (bad assembly), aarch64 (good assembly), and x86_64 macos (good assembly, which should also be the assembly for
-Zbuild-std)We could use a little unsafe and do something like:
to allow optimal code generation with just a new enough target in the caller without requiring recompiling std.