Skip to content

Add solution for Challenge 2 by macborowy #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add solution for Challenge 2 by macborowy #570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 33 additions & 0 deletions challenge-2/submissions/macborowy/solution-template.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package main

import (
"bufio"
"fmt"
"os"
)

func main() {
// Read input from standard input
scanner := bufio.NewScanner(os.Stdin)
if scanner.Scan() {
input := scanner.Text()

// Call the ReverseString function
output := ReverseString(input)

// Print the result
fmt.Println(output)
}
}

// ReverseString returns the reversed string of s.
func ReverseString(s string) string {
l := len(s)
a := make([]byte, l, l)

for i := len(s) - 1; i >= 0; i-- {
a[l-1-i] = s[i]
}

return string(a)
}
Comment on lines +24 to +33
Copy link
Contributor

@coderabbitai coderabbitai bot Oct 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🔴 Critical

Handle UTF-8 runes, not raw bytes.

Reversing by byte corrupts any multi-byte characters (e.g., "こんにちは" becomes invalid UTF-8). Convert to runes before reversing and rebuild the string.

Apply this diff:

-func ReverseString(s string) string {
-	l := len(s)
-	a := make([]byte, l, l)
-
-	for i := len(s) - 1; i >= 0; i-- {
-		a[l-1-i] = s[i]
-	}
-
-	return string(a)
-}
+func ReverseString(s string) string {
+	runes := []rune(s)
+	for i, j := 0, len(runes)-1; i < j; i, j = i+1, j-1 {
+		runes[i], runes[j] = runes[j], runes[i]
+	}
+	return string(runes)
+}
🤖 Prompt for AI Agents 
In challenge-2/submissions/macborowy/solution-template.go around lines 24 to 33,
the function reverses raw bytes which corrupts multi-byte UTF-8 characters;
convert the input string to a slice of runes, reverse that rune slice (swap rune
positions from ends toward center) and then return a new string from the
reversed rune slice so multi-byte characters are preserved.