Centralize TCPROS Server #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a single TCPROS server on the node to handle subscriber and service client connections. Previously each publisher and service was creating their own.
Collaborator
Author
|
@IanTheEngineer can you look at this and merge/dissent? |
Merged
| return new Promise((resolve, reject) => { | ||
| _createServer(resolve); | ||
| subscriber.on('error', () => { | ||
| this._log.warn('Sub %s had error', subscriber.name); |
Member
There was a problem hiding this comment.
Seems a bit funny to me that this error is reported as a warning. Was that intended?
Member
|
This pull request looks great. Sorry it took me so long to review. I'm going to merge as-is. At some point we should document/comment the functions as to their intended purposes (or at least the public-facing API). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a single TCPROS server on the node to handle subscriber and service client connections. Previously each publisher and service was creating their own. Connections are handed off to publishers and services according to the connection header.