Skip to content

Conversation

@chris-smith
Copy link
Collaborator

  • Adds support for anonymous option when calling initNode to anonymize your node name. Follows rospy logic.
  • Fixes error message when unable to find message package.
  • Also some unintended whitespace changes? Maybe from Atom?

e.g.

rospy.initNode('/my_node', {anonymous: true})
.then((nh) => {
   console.log( nh.getNodeName() ); // "/my_node_25878_1464120320242"
});

+ rosNode.getNodeName() + '] already exists');
}

// FIXME: validate nodeName -- MUST START WITH '/'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this FIXME still true? String validation of the node name hasn't changed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to remove it when I added the validation that exists. There is, admittedly, a lot more name validation/mapping that we need to do, though this exists for most ROS names and not specifically for node names.

@IanTheEngineer
Copy link
Member

Looks great overall. I'm ready to merge as is.

@IanTheEngineer IanTheEngineer merged commit ae121f9 into kinetic-devel May 25, 2016
@IanTheEngineer IanTheEngineer deleted the anonymousNode branch June 28, 2016 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants