Skip to content

Conversation

@chris-smith
Copy link
Collaborator

Updates node handle sub, pub, service api to more closely resemble other roscpp/rospy. When advertising/subscribing, can supply either a string 'std_msgs/String' or the class from rosjs.require('std_msgs')

e.g.

const StringMsg = rosjs.require('std_msgs').msg.String;

rosjs.advertise('chatter', 'std_msgs/String');
rosjs.advertise('chatter', StringMsg);

Adds some basic pub sub tests. Separates out gennodejs tests from client library tests so that people don't need to pull test_msgs down in order to run the client tests.

-Updates sub, pub, service api to more closely resemble
ROS' api.
-Adds basic pub/sub tests with stubbed master
-Separates gennodejs tests from standard rosnodejs tests
@IanTheEngineer
Copy link
Member

So this new api looks great, and likely what users will want. Can we support both the current and old API's in the future? That would make things slightly more flexible for users.

@IanTheEngineer IanTheEngineer merged commit bfddfde into kinetic-devel May 19, 2016
@IanTheEngineer IanTheEngineer deleted the apiUpdate branch June 28, 2016 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants