Skip to content

Conversation

@ketanreliefapps
Copy link
Contributor

@ketanreliefapps ketanreliefapps commented Mar 9, 2023

Description

Extend layer model, with new properties
To guide you, you can check the leaflet-esri repo I shared on slack dev channel
You would see some logs, we want to have something similar to what we see in operationalLayers there:
What is missing in current model and we want to replicate:

  • visibility
  • layerType -> only FeatureLayer at the moment
  • layerDefinition:
  • featureReduction: json
  • drawingInfo: json
  • popupInfo:
  • popupElements: array of JSON
  • description: text

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

currently i have done only backend

Checklist:

  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@AntoineRelief AntoineRelief merged commit 3043667 into feat/AB#16229_GIS Mar 9, 2023
@AntoineRelief AntoineRelief deleted the feat/AB#58619_extend_layer_model_in_back-end branch March 9, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants