Skip to content

Conversation

miguelaenlle
Copy link
Contributor

@miguelaenlle miguelaenlle commented Jun 6, 2025

Screen.Recording.2025-08-14.at.8.37.12.PM.mp4

Screenshots:

Screenshot 2025-08-14 at 8 34 29 PM Screenshot 2025-08-14 at 8 34 53 PM Screenshot 2025-08-14 at 8 35 13 PM

@Copilot Copilot AI review requested due to automatic review settings June 6, 2025 02:39
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new FAQ section to the Home page, rendering a list of questions with interactive hover effects and visual indicators.

  • Imports and displays the FAQ component on the homepage.
  • Implements the FAQ component with StopLight indicators and expandable FAQItem entries.
  • Defines a static list of FAQ items with questions and answers.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
apps/site/src/routes/Home.tsx Added import and <FAQ /> rendering in the Home route.
apps/site/src/components/Home/FAQ.tsx New FAQ component with hoverable questions and stoplight visuals.
Comments suppressed due to low confidence (1)

apps/site/src/components/Home/FAQ.tsx:1

  • There are no associated unit or integration tests for the new FAQ, StopLight, or FAQItem components. Adding tests will help ensure behavior remains correct as the UI evolves.
import { Box, Circle, HStack, Text, VStack } from "@chakra-ui/react";

Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2025

Deploying rp-web-hype with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bd0dfb
Status: ✅  Deploy successful!
Preview URL: https://88e2dc8b.rp-web-hype.pages.dev
Branch Preview URL: https://maenlle2-faq-page.rp-web-hype.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Jun 9, 2025

Deploying rp-web-admin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bd0dfb
Status: ✅  Deploy successful!
Preview URL: https://b0fb4255.rp-web-admin.pages.dev
Branch Preview URL: https://maenlle2-faq-page.rp-web-admin.pages.dev

View logs

Copy link

cloudflare-workers-and-pages bot commented Aug 12, 2025

Deploying rp-web-sponsor with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9bd0dfb
Status: ✅  Deploy successful!
Preview URL: https://171ddac8.rp-web-sponsor.pages.dev
Branch Preview URL: https://maenlle2-faq-page.rp-web-sponsor.pages.dev

View logs

@seventhriver seventhriver self-requested a review August 16, 2025 03:17
Copy link
Contributor

@seventhriver seventhriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing I would maybe consider (up to you if this is a good idea or not) -- since we can add more faq questions and it just cycles through the cars, but the cars are color-coded with the backgrounds, would it be better to define a matching array of {light, dark} color objects that we can just cycle through as well, instead of having to specify light/dark colors for each question? There might be a benefit to being able to specify each one, and it's not like it's difficult to, but I thought I'd mention it
(Also I left one other comment, I think a style got duplicated)

But yeah overall looks great! Seems pretty clean to me.

:root {
color: #213547;
background-color: #ffffff;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something but it looks like this was already here... I don't think it'd cause a problem but I don't think we need to have it twice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants