Skip to content

Conversation

@epsilon-0
Copy link
Contributor

@epsilon-0 epsilon-0 commented Nov 1, 2020

Very initial proof of concept PR, related to #461


This adds a BUILD_INDEX64 option which manages names for libraries.
Should have no effect with the default set to OFF.
When switched on, it will build the 64-suffixed libs.

Not a lot of testing done yet.
Just checked that BLAS64, CBLAS64, LAPACK64 and LAPACKE64 are building, with correct cmake and pkg-config files.
1/11/2020:
BLAS and CBLAS tests are working fine, LAPACK tests are still failing.
All tests are passing!

TODO:
Handle header file naming.
Fix printf/fprintf so that they don't give warnings of incompatible types.

@epsilon-0 epsilon-0 marked this pull request as draft November 1, 2020 03:08
@codecov
Copy link

codecov bot commented Nov 1, 2020

Codecov Report

Merging #462 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files        1863     1863           
  Lines      181096   181096           
=======================================
  Hits       148263   148263           
  Misses      32833    32833           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6870da...5dd47be. Read the comment docs.

@epsilon-0 epsilon-0 force-pushed the master branch 2 times, most recently from e58ca83 to a51ef96 Compare November 1, 2020 16:46
@epsilon-0 epsilon-0 marked this pull request as ready for review November 1, 2020 16:47
@langou langou merged commit 5e16b11 into Reference-LAPACK:master Nov 5, 2020
@epsilon-0
Copy link
Contributor Author

@langou
thanks a lot!

@drhpc
Copy link

drhpc commented Jun 3, 2021

Well, let's settle the headers now, please? See my comments on #461 … I am about to push the related changes to my PR #556 , after settling on fixing the headers or fixing the flags in the .pc and .cmake files.

mgorny added a commit to mgorny/lapack that referenced this pull request Sep 14, 2025
Add substitutions to `lapack.pc.in`, in order to ensure that
the generated `lapack64.pc` file correctly references the index64
library and BLAS dependency.  It seems that other pkg-config templates
have been updated as part of Reference-LAPACK#462 but this one was omitted.
As a result, finding a lapack64 via pkg-config gave a non-index64
libraries.

Signed-off-by: Michał Górny <[email protected]>
mgorny added a commit to mgorny/lapack that referenced this pull request Sep 14, 2025
Add substitutions to `lapack.pc.in`, in order to ensure that
the generated `lapack64.pc` file correctly references the index64
library and BLAS dependency.  It seems that other pkg-config templates
have been updated as part of Reference-LAPACK#462 but this one was omitted.
As a result, finding a lapack64 via pkg-config gave non-index64
libraries.

Signed-off-by: Michał Górny <[email protected]>
@mgorny mgorny mentioned this pull request Sep 14, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants