cmake: Tell CMake that our Fortran sources are in fixed format #399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake will automatically generate the proper flag to tell each compiler that our sources use fixed format. Drop our manual use of `-qfixed` for the XL Fortran compiler because it breaks CMake's FortranCInterface detection (which uses free-format sources).
Codecov Report
@@ Coverage Diff @@
## master #399 +/- ##
=======================================
Coverage 83.24% 83.24%
=======================================
Files 1808 1808
Lines 170183 170183
=======================================
Hits 141666 141666
Misses 28517 28517 Continue to review full report at Codecov.
|
Contributor
|
Thank you @bradking |
christoph-conrads
pushed a commit
to christoph-conrads/lapack
that referenced
this pull request
May 23, 2021
…ixed-format cmake: Tell CMake that our Fortran sources are in fixed format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake will automatically generate the proper flag to tell each compiler
that our sources use fixed format. Drop our manual use of
-qfixedforthe XL Fortran compiler because it breaks CMake's FortranCInterface
detection (which uses free-format sources).