Skip to content

Fixes / Python 3 compatibility #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fixes / Python 3 compatibility #5

wants to merge 8 commits into from

Conversation

hootnot
Copy link
Contributor

@hootnot hootnot commented May 27, 2017

Fix:

  • import of unittest module (test won't run without this import)

client.py / test.py

  • python 3 compatibility by using six

changes to test.py to:

  • simplify the tests by using setUp method in testcase
  • PEP8 / flake8 corrections

Tests run both 2.7 and 3.5

Gendoc seems pretty incompatible with Python 3.x

@itamarhaber
Copy link
Collaborator

itamarhaber commented Jun 4, 2017

Thanks for this PR @hootnot, and my apologies for the delay in my response.

I'd really like v3 support - I know next to nothing about the nuances and your help is much appreciated. However.

Trying to run the test with Python 3 and your PR results in complaints about iteritems (removed in v3, naturally). Would you be kind enough to fix the PR so the test works?

@itamarhaber
Copy link
Collaborator

I've added Travis CI so we can test this too.

@hootnot
Copy link
Contributor Author

hootnot commented Jun 4, 2017

Nice! will take a look at it ... see #6, discard this one

@itamarhaber itamarhaber closed this Jun 5, 2017
@hootnot hootnot deleted the compat branch June 5, 2017 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants