Skip to content

implement array and string commands #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 22, 2021
Merged

implement array and string commands #34

merged 4 commits into from
Mar 22, 2021

Conversation

bsbodden
Copy link
Contributor

This PR implements:

  • JSON.STRAPPEND
  • JSON.STRLEN
  • JSON.ARRAPPEND
  • JSON.ARRINDEX
  • JSON.ARRINSERT
  • JSON.ARRLEN
  • JSON.ARRPOP
  • JSON.ARRTRIM

@codecov
Copy link

codecov bot commented Mar 20, 2021 •
edited
Loading

Codecov Report

Merging #34 (42aa25f) into master (42aa25f) will not change coverage.
The diff coverage is n/a.

❗ Current head 42aa25f differs from pull request most recent head 5c7c067. Consider uploading reports for the commit 5c7c067 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #34   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files           2        2           
  Lines          24       24           
=======================================
  Hits           23       23           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42aa25f...5c7c067. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2021

This pull request introduces 27 alerts when merging 2e24699 into 42aa25f - view on LGTM.com

new alerts:

  • 27 for Spurious Javadoc @param tags

@bsbodden bsbodden force-pushed the bsb/implement-array-and-string-commands branch from 2e24699 to 0d2356b Compare March 20, 2021 04:12
@bsbodden
Copy link
Contributor Author

This pull request introduces 27 alerts when merging 2e24699 into 42aa25f - view on LGTM.com

new alerts:

  • 27 for Spurious Javadoc @param tags

Addressed and forced pushed a fix

@lgtm-com
Copy link

lgtm-com bot commented Mar 20, 2021

This pull request introduces 3 alerts when merging 0d2356b into 42aa25f - view on LGTM.com

new alerts:

  • 3 for Spurious Javadoc @param tags

@bsbodden bsbodden force-pushed the bsb/implement-array-and-string-commands branch from 0d2356b to f156711 Compare March 20, 2021 04:38
@bsbodden bsbodden changed the title Bsb/implement array and string commands implement array and string commands Mar 20, 2021
@bsbodden bsbodden force-pushed the bsb/implement-array-and-string-commands branch from f156711 to f03631e Compare March 20, 2021 04:54
@bsbodden bsbodden force-pushed the bsb/implement-array-and-string-commands branch from f03631e to 2cf5e39 Compare March 20, 2021 05:02
@gkorland gkorland requested a review from sazzad16 March 20, 2021 14:03
sazzad16
sazzad16 reviewed Mar 21, 2021
View reviewed changes
@gkorland gkorland merged commit 4258d9e into RedisJSON:master Mar 22, 2021
@bsbodden bsbodden deleted the bsb/implement-array-and-string-commands branch March 22, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sazzad16 sazzad16 sazzad16 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bsbodden @sazzad16 @gkorland