Remove unused logic for handling null entities #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #71 +/- ##
==========================================
- Coverage 84.00% 83.87% -0.14%
==========================================
Files 8 8
Lines 544 552 +8
==========================================
+ Hits 457 463 +6
- Misses 87 89 +2
Continue to review full report at Codecov.
|
jeffreylovitz
commented
Apr 6, 2020
| COLUMN_NODE = 2 | ||
| COLUMN_RELATION = 3 | ||
| COLUMN_NODE = 2 # Unused as of RedisGraph v2.1.0, retained for backwards compatibility. | ||
| COLUMN_RELATION = 3 # Unused as of RedisGraph v2.1.0, retained for backwards compatibility. |
There was a problem hiding this comment.
I've been using 2.1.0 as a placeholder because I think it is a sensible choice, but can rewrite these as 2.0.11 if preferred.
swilly22
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.