Don't attempt to decode NULL graph entities #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
======================================
- Coverage 84.2% 84% -0.2%
======================================
Files 8 8
Lines 538 544 +6
======================================
+ Hits 453 457 +4
- Misses 85 87 +2
Continue to review full report at Codecov.
|
DvirDukhan
approved these changes
Mar 30, 2020
swilly22
suggested changes
Mar 31, 2020
| @@ -219,6 +227,9 @@ def pretty_print(self): | |||
| def is_empty(self): | |||
| return len(self.result_set) == 0 | |||
|
|
|||
| def is_null_scalar(self, cell): | |||
| return cell == [ResultSetScalarTypes.VALUE_NULL, None] | |||
There was a problem hiding this comment.
return ResultSetCell_GetType(cell) == ResultSetScalarTypes.VALUE_NULL
swilly22
approved these changes
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker for OPTIONAL MATCH.