Valgrind memory leak test

[gkorland]

Most of leaks are within corner cases ( disconnects, bad input, etc... ).

• Common Commands ( TENSORSET, TENSORGET )
  make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_common.py"

• TF
  make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tensorflow.py"

  • test_run_tf_model
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tensorflow.py\:test_run_tf_model"

  • test_run_tf_model_errors ( severall leaks )
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tensorflow.py\:test_run_tf_model_errors"

  • test_tensorflow_modelinfo potential leak on redis createEmbeddedStringObject ( needs further investigation ) #298
    this a leak that appears multiple times on our tests and it can be either a missuse in our side or a real leak on redis. We should investigate further prior that creating an issue on redis himself.
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tensorflow.py\:test_tensorflow_modelinfo"

  • test_tensorflow_modelrun_disconnect ( larger on TF )
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tensorflow.py\:test_tensorflow_modelrun_disconnect"

• TFLite (see memleak on tfliteRunModel toManagedDLPack(interpreter, tflite_outputs[i]); #288)
  make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tflite.py"

  • test_run_tflite_model
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tflite.py\:test_run_tflite_model"

  • test_tflite_modelinfo
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tflite.py\:test_tflite_modelinfo"

  • test_tflite_modelrun_disconnect ( larger on tflite )
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_tflite.py\:test_tflite_modelrun_disconnect"

• ONNX
  make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_onnx.py"

  • test_onnx_modelinfo ( same as test_tensorflow_modelinfo ) potential leak on redis createEmbeddedStringObject ( needs further investigation ) #298
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_onnx.py\:test_onnx_modelinfo"

  • test_onnx_modelrun_disconnect ( same as test_tensorflow_modelinfo ) potential leak on redis createEmbeddedStringObject ( needs further investigation ) #298
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_onnx.py\:test_onnx_modelrun_disconnect"

• PYTORCH
  make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_pytorch.py"
  leaks on:

  • test_pytorch_modelrun_disconnect
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_pytorch.py\:test_pytorch_modelrun_disconnect"
  • test_pytorch_scriptrun_disconnect
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_pytorch.py\:test_pytorch_modelrun_disconnect"
  • test_pytorch_scriptset
    make -C opt test GEN=0 SLAVES=0 AOF=0 VALGRIND=1 TEST="tests_pytorch.py\:test_pytorch_scriptset"

[mnunberg]

I've found some leaks, but I want to wait for the command refactor to go in before fixing them

[lantiga]

Hey @mnunberg, feel free to send me a preview of the leaks you found, most of them are probably fixable quickly.

[K-Jo]

Any update on this?

[filipecosta90]

@gkorland @K-Jo @lantiga and @hhsecond .
re-opened this issue with further updates from new tests.

[filipecosta90]

@lantiga on PR #296 I've splitted the modelrun on TF into two tests since they handle different behaviours.