Skip to content

Conversation

@filipecosta90
Copy link
Collaborator

This PR addresses the issues discussed in #98. Thank you @mixadior for bringing this up.

@filipecosta90 filipecosta90 linked an issue Jan 13, 2021 that may be closed by this pull request
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #99 (7e00d34) into master (4f1c7d9) will increase coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   76.76%   76.95%   +0.18%     
==========================================
  Files          13       13              
  Lines        1089     1089              
==========================================
+ Hits          836      838       +2     
+ Misses        197      196       -1     
+ Partials       56       55       -1     
Impacted Files Coverage Δ
redisearch/client.go 79.83% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1c7d9...7e00d34. Read the comment docs.

Copy link

@emmanuelkeller emmanuelkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@filipecosta90 filipecosta90 merged commit df7bf7a into master Jan 22, 2021
@filipecosta90 filipecosta90 deleted the gomod.tidy branch January 22, 2021 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

How to use v2.0.2 version in project

3 participants