Skip to content

Conversation

@filipecosta90
Copy link
Collaborator

Changes included in this PR

@filipecosta90 filipecosta90 changed the title NewSchema fix and extnded testing for SerializeSchema NewSchema fix and extended testing for SerializeSchema Apr 12, 2020
@codecov
Copy link

codecov bot commented Apr 12, 2020

Codecov Report

Merging #58 into master will increase coverage by 2.43%.
The diff coverage is 85.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
+ Coverage   72.78%   75.22%   +2.43%     
==========================================
  Files          12       12              
  Lines        1117     1118       +1     
==========================================
+ Hits          813      841      +28     
+ Misses        240      220      -20     
+ Partials       64       57       -7     
Impacted Files Coverage Δ
redisearch/query.go 81.81% <ø> (+6.93%) ⬆️
redisearch/schema.go 91.91% <85.18%> (+16.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4cac87...17c02c4. Read the comment docs.

@filipecosta90 filipecosta90 merged commit 42408e1 into master Apr 21, 2020
@filipecosta90 filipecosta90 deleted the schema.fix branch April 21, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NewSchema ignores opts arg

3 participants