Skip to content

fix: close overlay on mobile nav after hash link click #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 6, 2025
Merged

fix: close overlay on mobile nav after hash link click #388

merged 3 commits into from
Oct 6, 2025

Conversation

@markcaron
Copy link
Collaborator

@markcaron markcaron commented Oct 6, 2025

  • Mobile nav overlay (when open) now closes when a hash link is clicked.

Testing / Issue

  1. Open navigation on mobile on live site
  2. Click Projects or Contribute
  3. Notice the overlay doesn't disappear
  4. Compare with local dev branch

@markcaron markcaron requested a review from adamjohnson October 6, 2025 15:20
adamjohnson
adamjohnson reviewed Oct 6, 2025
View reviewed changes
adamjohnson
adamjohnson approved these changes Oct 6, 2025
View reviewed changes
Copy link
Collaborator

@adamjohnson adamjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love Getting Toggled Menus

@markcaron markcaron merged commit 1704495 into dev Oct 6, 2025
4 checks passed
@markcaron markcaron deleted the fix/hash-link-overlay branch October 6, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamjohnson adamjohnson adamjohnson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@markcaron @adamjohnson