Skip to content

Conversation

@jcdevs
Copy link
Contributor

@jcdevs jcdevs commented Jun 29, 2025

  • Account creation and login
  • Create characters for account
  • Claim legacy characters for account using character password
  • Play any character belonging to the account or that have granted proxy access to any of the account's characters
  • Optionally set an email on the account
  • Accounts gain xp at a rate of 1% of player xp
  • account command with subcommand info
  • Support legacy <character name> login temporarily to opt out of accounts

@jcdevs jcdevs changed the title Account baseline data layer Accounts Jul 2, 2025
ocelot134269
ocelot134269 previously approved these changes Jul 15, 2025
@ocelot134269 ocelot134269 dismissed their stale review August 31, 2025 09:37

Need Bane to review instead of me.

ocelot134269
ocelot134269 previously approved these changes Oct 15, 2025
Copy link
Contributor

@ocelot134269 ocelot134269 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Instead of:
    Please enter account name
    (or legacy to login without an account):

Please choose one:
A) Enter your RoH account name. (We will create one for you if it does not exist)
B) Skip accounts for now and log in with a character name.
:

  1. If account is new, make sure to tell them they are creating a new account...I dunno..something like:
    "Welcome to Realms of Hell MUD! What password will the account 'thisAccount' be using?"

If not new, instead of "Please enter account password" say "Please enter password for account 'thisAccount':"

  1. Make sure we're checking new account names against CONFIGPATH/forbidden_name.txt file.
    They choose an account that matches anything in that file, it says like "Please choose another account name. That one is not available." or something. Alternatively, make a "forbidden_account_name.txt" file. Although i think using the existing one for names should be fine.

  2. Spice up account menu, instead of:


Account:    Ocelot
Characters: 1/60
Experience: 0

Commands:
  (c)reate  - Create a new character
  (l)ist    - List your characters
  (cl)aim   - Claim a legacy character
  (e)mail   - Set email address
  (q)uit    - Disconnect

Or enter a character name to play.

Enter a command:


I suggest prettying it up a bit more. Something like:

~~~~~~~ Account Menu ~~~~~~~

Account:    Ocelot
Characters: 1/60
Account Legacy Experience: 0

Account Commands:
  ^c(c)^xreate  - Create a new character for this account
  ^c(l)^xist    - List this account's characters
  ^c(cl)^xaim   - Claim a legacy character for this account
  ^c(e)^xmail   - Set/Reset this account's email address
  ^c(q)^xuit    - Disconnect

Enter an account command, or enter a character name to play:


5. Instead of:
Invalid command. Available commands: (c)reate, (l)ist, (cl)aim, (e)mail, (q)uit
Or enter a character name to play.

I'd say do "Invalid command. Please choose a command." and then just reprint the account menu.
At the very least, put a \n after "Invalid command." so there's a line break.

@ocelot134269 ocelot134269 self-requested a review October 15, 2025 03:03
@ocelot134269 ocelot134269 dismissed their stale review October 15, 2025 03:04

Accidentally approved since i am a github n00b. It's almost ready but not quite yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants