BehaviorSubject.getValue() always returns initial value if subscribed to observable from Webpack library

[es-repo]

Bug Report

Current Behavior

BehaviorSubject.getValue() always returns initial value if subscribed to an observable from Webpack library while the observable is emitting new values.

Reproduction

-Minimum code which reproduces bug:
https://github.com/es-repo/bug-repro/tree/master/rxjs/behavior-subject-and-observable-from-lib

Run "npm start" from within the "app" folder or open this link https://es-repo.github.io/bug-repro/rxjs/behavior-subject-and-observable-from-lib/app/dist/. And open console.

Code from the "app" which reproduces the issue:

import { BehaviorSubject, interval } from 'rxjs';
import createObservable from 'lib';

const subject1 = new BehaviorSubject(undefined);
createObservable().subscribe(subject1);

const subject2 = new BehaviorSubject(undefined);
interval(1000).subscribe(subject2);

subject1.subscribe(v => {
  console.log(`Observable from lib: value=${v} getValue()=${subject1.getValue()}`);
});

subject2.subscribe(v => {
  console.log(`Observable from app: value=${v} getValue()=${subject2.getValue()}`);
});

Code from the "lib":

import { interval } from 'rxjs';

export default function createObservable() {
  return interval(1000);
}

Console output:

Observable from lib: value=undefined getValue()=undefined
Observable from app: value=undefined getValue()=undefined
Observable from lib: value=0 getValue()=undefined
Observable from app: value=0 getValue()=0
Observable from lib: value=1 getValue()=undefined
Observable from app: value=1 getValue()=1
...

Expected behavior

BehaviorSubject.getValue() should return last value emitted from Observable.

Environment

• Runtime: Node v12.7.0, Chrome v78
• RxJS version: 6.5.3
• Webpack: 4.41.2

Additional context

Related issue: #5051

[samal-rasmussen]

Hi es-repo. I made a pull request to your reproduction that adds a working example that uses an app local source.

[es-repo]

Thanks, samal!

[Stradivario]

Who use to subscribe with other observable ?

const subject2 = new BehaviorSubject(undefined);
interval(1000).subscribe(subject2);

I don't think this is a correct usage and even i don't know what will happen that way passing observable directly as a subscription.

const subject2 = new BehaviorSubject(undefined);
interval(1000).pipe(mergeMap(() => subject2)).subscribe(console.log)
subject2.next(true)

[es-repo]

Who use to subscribe with other observable ?

const subject2 = new BehaviorSubject(undefined);
interval(1000).subscribe(subject2);

@Stradivario sorry, could you elaborate what do you mean?
observable.subscribe(subject) is how you convert unicast observable into multicast. Or, in another way, subject is both an observable and an observer and as an observer it can be subscribed to observable. What's wrong here from your point of you?

[Stradivario]

Who use to subscribe with other observable ?

const subject2 = new BehaviorSubject(undefined);
interval(1000).subscribe(subject2);

@Stradivario sorry, could you elaborate what do you mean?
observable.subscribe(subject) is how you convert unicast observable into multicast. Or, in another way, subject is both an observable and an observer and as an observer it can be subscribed to observable. What's wrong here from your point of you?

Never seen such a composition of observables i am really sorry if i miss understood it. I just prefer different approach of composing with pipe. My subscribe method is the last thing that i will write even i try to not write subscribe in my code. That's a different scenario and mind set which doesn't belong to me and i will try to get the best from it.

Regards and Merry Christmas,
Kristiyan Tachev

[cartant]

This is a bug, but it cannot easily be fixed. The problem is that the subject isn't seen as a safe/trusted subscriber because the interop source won't see the per-package Symbol that identifies the subject as trusted.

And that means that the subject will be 'cloned' so that an unsubscribe method can be added to it:

rxjs/src/internal/Subscriber.ts

Lines 189 to 193 in f8a4876

	context = Object.create(observerOrNext);
	if (isFunction(context.unsubscribe)) {
	this.add(<() => void> context.unsubscribe.bind(context));
	}
	context.unsubscribe = this.unsubscribe.bind(this);

And that means the the subject's original state will remain unchanged - the bug you reported.