Remove CHM check to allow reusing the Subscriber instance #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 79.41% (diff: 81.81%)@@ 1.x #159 diff @@
==========================================
Files 8 8
Lines 278 272 -6
Methods 0 0
Messages 0 0
Branches 51 49 -2
==========================================
- Hits 219 216 -3
+ Misses 30 28 -2
+ Partials 29 28 -1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump to RxJava 1.2.2
Remove the CHM that checked if someone subscribed with the same RS Subscriber instance twice. It has performance penalty and otherwise over-restrictive in some cases where the downstream reuses the same Subscriber instance in a completely safe manner.