Skip to content

Conversation

akarnokd
Copy link
Member

Add Java 8 operators to the ParallelFlowable class:

  • mapOptional + 2
  • flatMapStream + 1
  • collect

Also for symmetry, the flatMapIterable operator has also been added.

Cleanups:

  • Add missing @since tags, unify tag location.
  • Use diamond in parallel classes.
  • Fix error messages in the parallel-try operators.
  • Improve validation messages with at entries so the IDE can navigate to the problematic line.
  • Add some unit tests to improve coverage of some existing parallel operators.

@akarnokd akarnokd added Enhancement Cleanup 3.x Java 8 Issues and PRs related to Java 8 support labels Dec 26, 2019
@akarnokd akarnokd added this to the 3.0 milestone Dec 26, 2019
@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #6798 into 3.x will decrease coverage by 0.01%.
The diff coverage is 99.01%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6798      +/-   ##
============================================
- Coverage     98.23%   98.22%   -0.02%     
- Complexity     6340     6374      +34     
============================================
  Files           706      711       +5     
  Lines         45846    46217     +371     
  Branches       6280     6329      +49     
============================================
+ Hits          45039    45398     +359     
- Misses          283      297      +14     
+ Partials        524      522       -2
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 177 <0> (ø) ⬇️
...ain/java/io/reactivex/rxjava3/core/Observable.java 100% <ø> (ø) 553 <0> (ø) ⬇️
.../main/java/io/reactivex/rxjava3/core/Flowable.java 100% <ø> (ø) 577 <0> (ø) ⬇️
...ava3/internal/operators/parallel/ParallelPeek.java 98.94% <100%> (ø) 5 <0> (ø) ⬇️
...vex/rxjava3/internal/jdk8/ParallelMapOptional.java 100% <100%> (ø) 6 <6> (?)
...va3/internal/operators/parallel/ParallelRunOn.java 97.1% <100%> (ø) 8 <0> (ø) ⬇️
...internal/operators/parallel/ParallelFilterTry.java 97.34% <100%> (ø) 6 <0> (ø) ⬇️
...a3/internal/operators/parallel/ParallelFilter.java 97.59% <100%> (ø) 6 <0> (ø) ⬇️
...al/operators/flowable/FlowableFlattenIterable.java 100% <100%> (ø) 5 <1> (+1) ⬆️
...nternal/operators/parallel/ParallelSortedJoin.java 95.62% <100%> (+0.72%) 2 <1> (ø) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af17c6e...c8fe9ab. Read the comment docs.

@akarnokd akarnokd merged commit 3d00eb1 into ReactiveX:3.x Dec 26, 2019
@akarnokd akarnokd deleted the ParallelFlowableJava8Ops branch December 26, 2019 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Cleanup Enhancement Java 8 Issues and PRs related to Java 8 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant