Refactoring #6
Merged
Refactoring #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benjchristensen
commented
Jan 16, 2013
benjchristensen
commented
- convert to rx.* package names
- rx.observables
- rx.observables.operations (private package from javadocs)
- rx.util
- rx.lang
- rx.concurrency (placeholder for schedulers)
- change Func order to have return type at end => T, R instead of R, T
- this matches the C# and Guava conventions
- added Action as Func without return value
- added overload subscribe methods with Action typed arguments
- added from() alias methods in Observable
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…e rate is above (>) the threshold, but it should be above or equal (>=).
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
…e rate is above (>) the threshold, but it should be above or equal (>=).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.