1.x: add missing RxJavaHooks options, fix bugs #4182
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Thread.currentThread().setUncaughtExceptionHandler(null); | ||
|
|
||
| // this will be printed on the console and should not crash |
There was a problem hiding this comment.
You could actually test this by setting System.err to something that records, but it would be a bit much.
|
Lgtm 👍 |
|
Thanks @JakeWharton . Travis CI doesn't execute the build for like 30 minutes now... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These PR adds the remaining hooks which weren't even tested with the original RxJavaPlugins plus a full coverage of the RxJavaHooks itself.
This is a mandatory addition and 1.1.7 can't be released without it (i.e., with an incomplete RxJavaHooks that is).