Refactor private constructor checker into a utility class #4133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 81.25%@@ 1.x #4133 diff @@
==========================================
Files 257 257
Lines 16811 16811
Methods 0 0
Messages 0 0
Branches 2547 2547
==========================================
- Hits 13666 13659 -7
- Misses 2243 2245 +2
- Partials 902 907 +5
|
|
👍 |
| /** | ||
| * Common test utility methods. | ||
| */ | ||
| public enum TestUtil { |
There was a problem hiding this comment.
Just curious - why use an enum here instead of a class? Is it just to forbid inheritance?
There was a problem hiding this comment.
Exactly - but not my invention. I saw this in the JDK source and in fact, saves you testing a private constructor. However, we can't expose such enums through the public API so only some internal tools are defined this way.
|
/cc @davidmoten |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move into
TestUtil.checkUtilityClass().