Renamed Completable#finallyDo to #doAfterTerminate #3568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1926,7 +1926,7 @@ public void onCompleted() { | |||
| public void finallyDoWithError() { | |||
There was a problem hiding this comment.
Maybe the test names should be changed as well.
stealthcode
force-pushed
the
RenameCompletableFinallyDo
branch
from
c87bacd to
8646d8d
Compare
|
👍 |
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Dec 9, 2015
Renamed Completable#finallyDo to #doAfterTerminate
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames as part of #3434 for the recently added Completable.