Skip to content

Renamed Completable#finallyDo to #doAfterTerminate #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 9, 2015

Conversation

stealthcode
Copy link

Renames as part of #3434 for the recently added Completable.

@@ -1926,7 +1926,7 @@ public void onCompleted() {
public void finallyDoWithError() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the test names should be changed as well.

@stealthcode stealthcode force-pushed the RenameCompletableFinallyDo branch from c87bacd to 8646d8d Compare December 9, 2015 10:14
@artem-zinnatullin
Copy link
Contributor

👍

@akarnokd
Copy link
Member

akarnokd commented Dec 9, 2015

👍

akarnokd added a commit that referenced this pull request Dec 9, 2015
Renamed Completable#finallyDo to #doAfterTerminate
@akarnokd akarnokd merged commit 3fdfa51 into ReactiveX:1.x Dec 9, 2015
@stevegury
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants