1.x: update and bugfix to SubscribingPerf #3480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two of the tests used the wrong subscriber. Added a benchmark which should help verify the overhead of checking isUnsubscribed within range in ReactiveX#3479 because I suspect that will get worse there.
akarnokd
added a commit
that referenced
this pull request
Oct 29, 2015
1.x: update and bugfix to SubscribingPerf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this doesn't change any main class, just a perf class.
Subscribers via blackhole, this JIT optimization is negated as it should be.isUnsubscribedwithin range in 1.x: reduce Subscriber's creation overhead #3479 because I suspect that will get worse there.Benchmark values: (i7 4790, Windows 7 x64, Java 8u66):