Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move all blocking operators to
BlockingObservable
. This has breaking changes for anything using blocking operators ... part of the pursuit of establishing a clean API on our path to 1.0.This is something I've been wanting to do for a while but got the push over the ledge via discussion at #270.
This strays from "match Rx.Net as closely as possible" but feels justified for the following reasons:
take
andtakeLast
is non-obvious)I have removed all blocking operators from
Observable
and put them inBlockingObservable
. I have leftObservable.toBlockingObservable
as a means of going from one to the other as it is an obvious communication of what is now being permitted.While doing this I also cleaned up some odd API artifacts such as
toObservable
vsfrom
and moved implementation specific code fromrx.util
into the internal packagerx.operators
where all code reserves the right to change at any time.I intend on releasing this as version 0.9.