Serialized backpressure support proposal. #1774
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
We don't need to delay the error ... just emit it and skip everything else. We confirmed this behavior in observeOn: #1680
|
This PR is kind of old and lots of things happened in lock-free world recently so I'll revisit the issue again in a new PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #1671
It took me a while to get it working and I'm not sure what tests to write to check backpressure behavior besides the request 5s from a sequence of 15.
In addition, it was a bit confusing when to call onStart, what exactly the setProducer call supposed to do and what to do when noone calls setProducer from upstream.