You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I found a couple small instances of ObjectHelper.requireNonNull being used on primitive ints, which I patched in #6012 . Does the Rx codebase have a code pattern checking framework that we could augment to find other potential instances of this that could be causing unnecessary boxing? Errorprone, for example, has this check: https://errorprone.info/bugpattern/PreconditionsCheckNotNullPrimitive for a similar pattern on Guava's Preconditions.checkNotNull, so having one for ObjectHelper could be potentially useful here.
The text was updated successfully, but these errors were encountered:
I found a couple small instances of
ObjectHelper.requireNonNull
being used on primitive ints, which I patched in #6012 . Does the Rx codebase have a code pattern checking framework that we could augment to find other potential instances of this that could be causing unnecessary boxing? Errorprone, for example, has this check: https://errorprone.info/bugpattern/PreconditionsCheckNotNullPrimitive for a similar pattern on Guava'sPreconditions.checkNotNull
, so having one forObjectHelper
could be potentially useful here.The text was updated successfully, but these errors were encountered: