Minimize library size

[pasviegas]

Hey, I am thinking about using the library in an android app, but the library size is close to 1mb.

I saw that the unit tests are being packaged with the production code, is there any reason for that?

Would be possible to reduce the library size?

[Andrei-Pozolotin]

+1

[benjchristensen]

Reason: https://github.com/Netflix/RxJava/blob/master/rxjava-core/src/test/java/README.md

Discussed here: #297

Doesn't everyone use ProGuard (http://developer.android.com/tools/help/proguard.html) to strip unused byte code and reduce file size of Android apps anyways which makes this moot?

Does a couple hundred KB really affect Android apps that significantly (particularly in light of ProGuard usage)?

[benjchristensen]

Any further comments on my questions about ProGuard?

[codefromthecrypt]

Here at square, the android team take a lot of care to keep distributions small. This issue does come up as more devs are experimenting with rxjava, and it came up again today.

It is too bad there's a problem with some languages that requires distributing inner test classes in jars. If it weren't for this, one could consider proguarding rxjava here, in the root project, and remove work for those consuming in android projects.

I'm hoping someone can be creative and determine a way to address the language issues mentioned so that we can use rxjava without increasing the complexity of proguard config in each project that uses rxjava.

[codefromthecrypt]

cc @RayFromSquare

[benjchristensen]

Hi @adriancole, nice to hear from you.

If it weren't for this, one could consider proguarding rxjava here, in the root project, and remove work for those consuming in android projects.

Agreed. This is what I used to do (not with ProGuard, just a simple exclude when creating the jar).

If this is such a big deal then let's move the unit tests out.

I still want to know though ... is it not normal for all Android projects to use ProGuard?

[codefromthecrypt]

hi back at you, @benjchristensen!

So, we have a number of camps. Some don't use proguard�, at times because some libraries don't work well with proguard (like dagger), which would lead to custom rules. Some here use it minimally for targeted obfuscation, but these rules are very simple. In short, usage isn't universal.

[benjchristensen]

Interesting, thanks for the insight.

Let's proceed with the unit test refactor.

[pasviegas]

Thanks! If you have any guideline in mind I can help with the refactor!

And thx for the awesome library!

[benjchristensen]

If you can help tackle this @pasviegas I'd appreciate it. I don't have time in the coming days to do this (focused on something else).

The way I was planning on doing this is taking each inner UnitTest call and refactoring out to a separate class with the same package name and class name + 'Test' suffix in the /src/test path.

For example:

Move /src/main/java/rx/operators/OperationAny.UnitTest https://github.com/Netflix/RxJava/blob/master/rxjava-core/src/main/java/rx/operators/OperationAny.java#L130 to /src/test/java/rx/operators/OperationAnyTest.java

[codefromthecrypt]

thanks @benjchristensen

[pasviegas]

just to keep everyone updated.

I'll probably send the pull request today. Just need to finish couple of classes, hehe.

[codefromthecrypt]

@pasviegas looking forward to it!