Skip to content

'lift(final Operator<? extends R, ? super T>)' has private access in 'rx.Single' #3161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
passsy opened this issue Aug 15, 2015 · 2 comments
Closed

Comments

@passsy
Copy link
Contributor

passsy commented Aug 15, 2015

I was expecting Single#lift() to be part of the public API like Observable#lift(). Is there a reason for this restriction?

Single#compose() is public, too (and links to #lift() in the docs). I guess the private access is just a bug.

https://github.com/ReactiveX/RxJava/blob/1.x/src/main/java/rx/Single.java#L176

My workaround:

Single.just("value")
        .toObservable()
        .lift(myOperator)
        .toSingle();
@akarnokd
Copy link
Member

Single is in experimental phase, its API is not stable and there wasn't enough confidence to open up many of the methods, including lift.

@akarnokd
Copy link
Member

I think the time has come to expose Single.lift(). PRs welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants