-
Notifications
You must be signed in to change notification settings - Fork 99
fastlane: slightly improve formatting for full descriptions #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0e93029
to
9308b97
Compare
@Razeeman any chance to get this merged? Would be quite good for the app's listing at IzzyOnDroid. And in case you're curious, some stats: ![]() |
Hello! Can you please share how does it look before the changes? Does it not render currently? Description is very important for Google Play, so I'd rather not change it without running A/B tests. |
To do that, I'd need to void the changes here, create an index with that, and take screenshots with multiple clients (look might depend on that), then revert the changes, and rebuild the index again – which would take more than an hour I currently don't have… But looking at the diff, let me simulate it here:
versus
is the closest I can get here. In short: each bullet point would become its own list, and not all line breaks would be recognized with "unflavored" standard markdown.
Sorry, I cannot run those. It's plain text for Google, and nothing much changes there. If you insist, the graphical bullet points could be restored (we meanwhile updated our importer so it now recognizes and converts them on import). The most important thing there is the empty lines between the bullet points, which would break the list here, and the line break inside each bullet point which would get lost. |
Thank you for the explanation. If I understood correctly, there is a parser that parses bullet point symbol as a bulleted list, and formatting gets broken. Is there a possibility to disable this bulleted list parsing and show description as simple text like in Google Play? Maybe only for this repository? Or adjust it to not remove new lines? It seems somewhat limiting to change description to get a correct bulleted list working. |
It seems more like a "to each is own" stylistic choice. For me, text on the second screenshot seems easier to read, it is separated, has more space. Hope this makes sense. |
Not forcing this upon you – it's your app, so your choice. If you want us (IzzyOnDroid) to switch to F-Droid like plain-text interpretation, we can of course do that – and close this PR unmerged (with the proper cleanup). |
So for clarity's sake: shall I withdraw my PR then, and switch interpretation to "plain text" (i.e. just replacing line breaks with |
Sorry, got carried away. Yes, this is probably would be best for now. Thank you for the understanding! |
All good! It's your app, so your decision. No bad feelings at all! Cleaned up on our end then, and switched the config to pick up your variant, converting line breaks to |
This PR slightly improves formatting of the English full description, making it possible to render it as Markdown (supported e.g. at IzzyOnDroid) while keeping it compatible with places not supporting it (e.g. F-Droid.org, PlayStore).
Please forgive me not having applied it to all locales, but only to those with character sets I knew how to deal with 🙈