Skip to content

Fixed UVs not generated on model #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed UVs not generated on model #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d701215
Fixed UVs not generated on model
maxcana May 9, 2025
c9567b4
Update ChiselModelManager.cs
maxcana Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Components/Managers/ChiselModelManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,11 @@ public void Rebuild(ChiselModelComponent model)
}

UpdateModelFlags(model);

if(model.AutoRebuildUVs)
{
ForceUpdateDelayedUVGeneration();
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late comment, I was on vacation and then forgot .. 😬
Also, it's been a while since I looked at this particular code
So, DelayedUVGeneration works on all models, so this is not the right place for this.
In UpdateModels() DelayedUVGeneration is called, after all models are done, and it should already run if ForceUpdateDelayedUVGeneration has been called before
So just calling ForceUpdateDelayedUVGeneration here should be enough

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I haven't tested it with just ForceUpdateDelayedUVGeneration() but if you are sure, we can resolve this :)

}

public bool IsDefaultModel(UnityEngine.Object obj)
Expand Down