Skip to content

Conversation

yangjie11
Copy link
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

在什么测试环境下测试通过 (what is the test environment)

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

@mysterywolf mysterywolf marked this pull request as draft June 13, 2023 02:14
Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/RTduino/RTduino/blob/master/core/SConscript#L16

把这一行放进来,可以有效减低开启C++的资源开销

@mysterywolf
Copy link
Member

我来改吧。

@mysterywolf mysterywolf changed the title 为c++增加 rt-thread 多线程支持的子开关 [cpp] support rt-thread CPP wrapper sub-switch macros Jun 14, 2023
@mysterywolf mysterywolf requested a review from Guozhanxin June 14, 2023 04:05
Copy link
Member

@mysterywolf mysterywolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTduino下编译通过

@mysterywolf mysterywolf added the +1 Agree +1 label Jun 14, 2023
@mysterywolf mysterywolf marked this pull request as draft June 14, 2023 04:17
@mysterywolf mysterywolf force-pushed the cpp branch 2 times, most recently from cfc5a02 to 1f4ba84 Compare June 14, 2023 04:21
@mysterywolf mysterywolf marked this pull request as ready for review June 14, 2023 04:22
@mysterywolf mysterywolf force-pushed the cpp branch 2 times, most recently from f620175 to 40af4c7 Compare June 14, 2023 04:46
src += ['drv_wdt.c']

group = DefineGroup('Drivers', src, depend = [''], CPPPATH = CPPPATH)
group = DefineGroup('Drivers', src, depend = [''], CPPPATH = CPPPATH, CPPDEFINES=['NNCASE_NO_EXCEPTIONS'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是啥,怎么在这个pr里

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不使用c++ exception 降低资源开销

@mysterywolf mysterywolf merged commit 4f5ba63 into RT-Thread:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+1 Agree +1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants