-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[BSP] add nuclei bsp to CI testing #5855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
## 配置工具链前缀 | ||
|
||
由于RT-Thread 仓库在CI时使用的是risc-v通用编译器 `riscv-none-embed-` ,所以在编译前需要更改一下BSP根目录下rtconfig.py: | ||
|
||
> 修改工具链前缀PREFIX 为 `riscv-nuclei-elf-` | ||
``` | ||
if PLATFORM == 'gcc': | ||
# toolchains | ||
PREFIX = 'riscv-nuclei-elf-' | ||
CC = PREFIX + 'gcc' | ||
CXX = PREFIX + 'g++' | ||
AS = PREFIX + 'gcc' | ||
AR = PREFIX + 'ar' | ||
LINK = PREFIX + 'gcc' | ||
GDB = PREFIX + 'gdb' | ||
TARGET_EXT = 'elf' | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Guozhanxin 郭老师 CI这侧直接安装一个新的编译链吧 不要为了加入CI而改了BSP正常的工具链
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我本地测试的两个risc-v gcc:
github : https://github.com/xpack-dev-tools/riscv-none-embed-gcc-xpack/releases
nuclei: https://www.nucleisys.com/upload/files/toochain/gcc/nuclei_riscv_newlibc_prebuilt_linux64_2022.04.tar.bz2
都是基于10.2.0版本,实测两个编译器编译结果,运行效果一样,能把nuclei的编译链安装了最好,芯来可能做了一些优化之类的。如果新装,我把这些撤销掉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我是考虑能用已有的最好,再装一个,也就这两个bsp用,也只能测到编译,不太划算。。。最好找官方的人确认一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我本地测试的两个risc-v gcc: github : https://github.com/xpack-dev-tools/riscv-none-embed-gcc-xpack/releases nuclei: https://www.nucleisys.com/upload/files/toochain/gcc/nuclei_riscv_newlibc_prebuilt_linux64_2022.04.tar.bz2 都是基于10.2.0版本,实测两个编译器编译结果,运行效果一样,能把nuclei的编译链安装了最好,芯来可能做了一些优化之类的。如果新装,我把这些撤销掉
@fanghuaqi 用riscv-none-embed-gcc这个工具链会有什么问题吗,你们建议怎么改呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
建议采用我们官方的,我们官方做了P扩展的自定义指令(0.5.3版本),然后整合了bpv扩展的支持,而且CI也可以每次运行的时候下载工具链,然后cache起来,不用每次都下载
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
再安装工具链,对ci的负担实在有些太重了。或者只在bsp层面调整,并不加入到ci中?
感觉没必要专门来去刷日期啊,刷日期就导致很多文件更改了。 |
zephyr 的仓库也没修修改日期 |
因为涉及到太多的仅仅是日期的调整,建议这个PR重新进行修改;而对于工具链部分,两种建议:
鉴于上述情况,这个PR关闭,请重新调整,另行提交。 |
说明一下提交这个PR的原因: |
[
add nuclei bsp to CI testing
]
以下的内容不应该在提交PR时的message修改,修改下述message,PR会被直接关闭。请在提交PR后,浏览器查看PR并对以下检查项逐项check,没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up