[nuvoton] Upgrade LVGL to v81 #5399

wosayttn · 2021-12-17T09:41:06Z

拉取/合并请求描述：(PR description)

[

Support LVGLv81 RTT music demo on N9H30 and NUC980 platform.

You also can find LVGLv81 with GE2D supporting implementation in https://github.com/wosayttn/lvgl/tree/release/v8.1 .

Update Drivers
]

以下的内容不应该在提交PR时的message修改，修改下述message，PR会被直接关闭。请在提交PR后，浏览器查看PR并对以下检查项逐项check，没问题后逐条在页面上打钩。
The following content must not be changed in the submitted PR message. Otherwise, the PR will be closed immediately. After submitted PR, please use a web browser to visit PR, and check items one by one, and ticked them if no problem.

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

已经仔细查看过代码改动的对比 Already check the difference between PR and old code
代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
本拉取/合并请求代码是高质量的 Code in this PR is of high quality
本拉取/合并使用formatting等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification

bsp/nuvoton/nk-980iot/applications/lvgl/port/lv_port_disp.c

mysterywolf · 2021-12-17T12:42:22Z

bsp/nuvoton/nk-n9h30/applications/lvgl/port/lv_port_disp.c

+    /*Set the resolution of the display*/
+    disp_drv.hor_res = info.width;
+    disp_drv.ver_res = info.height;
+    disp_drv.full_refresh = 1;


这个参数请删除

The flag still keep in my testing.

We take care tearing issue on our platform is with internal LCD controller. So, we still need to keep the flag.

请留意一下这里，LVGL作者的回复：

https://forum.lvgl.io/t/v8-display-driver-double-buffer-low-fps-high-cpu/6901/5
这就是为什么我对这个参数很敏感的原因，根据作者的回答，这个参数会强制刷新整个屏幕。

处理完毕了请告诉我

Done. Please revise the LVGLv81 porting on Nuvoton platform again.

We also implemented direct_mode, full_refresh and two screen-sized buffers in the N9H30 porting. Let user has more choices.

bsp/nuvoton/nk-n9h30/applications/lvgl/port/lv_port_indev.c

bsp/nuvoton/nk-980iot/applications/lvgl/port/lv_port_indev.c

bsp/nuvoton/nk-980iot/applications/lvgl/port/lv_port_disp.c

bsp/nuvoton/nk-980iot/applications/lvgl/port/lv_demo.c

bsp/nuvoton/nk-n9h30/applications/lvgl/port/lv_demo.c

wosayttn · 2021-12-17T14:34:30Z

Thanks these comments. For full_refresh flag, I will verify the disabling before pushing next commit.

mysterywolf · 2021-12-17T19:59:04Z

我觉得你放在application里要比我放在board下面要更好，我也提pr改到application目录下！😄

bsp/nuvoton/nk-n9h30/applications/lvgl/port/lv_demo.c

mysterywolf · 2021-12-20T02:56:04Z

application/lvgl不必加port文件夹，直接application/lvgl即可

To avoid to overwrite larger firmware size with LVGL.

mysterywolf · 2021-12-21T01:35:02Z

处理完毕了请告诉我

bsp/nuvoton/nk-n9h30/applications/lvgl/lv_conf.h

bsp/nuvoton/nk-980iot/applications/lvgl/lv_conf.h

1. Add RTGRAPHIC_CTRL_PAN_DISPLAY and RTGRAPHIC_CTRL_WAIT_VSYNC control command. 2. Add calibration data of 480x272 ADC touching. 3. Add 480x272 LCD panel menu option and driver. 4. Update lv_conf.h.

mysterywolf · 2021-12-28T06:17:19Z

https://github.com/RT-Thread/rt-thread/blob/master/bsp/stm32/stm32l475-atk-pandora/board/Kconfig#L63-L67 需要给用户提供一个一键化配置LVGL的选项，在Hardware Drivers Config->Onboard Peripheral Drivers配置项里，名字叫做“Enable LVGL for LCD”

wosayttn · 2021-12-28T08:57:46Z

https://github.com/RT-Thread/rt-thread/blob/master/bsp/stm32/stm32l475-atk-pandora/board/Kconfig#L63-L67 需要给用户提供一个一键化配置LVGL的选项，在Hardware Drivers Config->Onboard Peripheral Drivers配置项里，名字叫做“Enable LVGL for LCD”

Hi,

Both LVGLv81 core and rtt_music_demo packages are enabled in default configuration file - .config.
So, the rtt_music_demo demonstrates on the board by default.

#5399 (comment)

mysterywolf · 2021-12-28T09:02:14Z

@wosayttn 这么做也可以，但是没有明确的依赖关系，用户去除掉这个功能很麻烦。我们现在的策略一般是默认这种附加功能不选定，如果用户需要，再选定，选定的时候Kconfig会自动选定依赖项。不要默认就把一堆的东西都开开起来，尤其是软件包什么的。

mysterywolf · 2021-12-28T09:02:52Z

下个pr再说这个问题吧

wosayttn · 2021-12-30T06:10:23Z

Thanks reviewer and merging.

ttnwosay added 2 commits December 17, 2021 17:20

Support LVGLv81 RTT music demo for N9H30 and NUC980.

b6b4218

[N9H30] Update readme.

bcaffdd

mysterywolf requested changes Dec 17, 2021

View reviewed changes

mysterywolf added the v4.1.0 label Dec 17, 2021

mysterywolf requested changes Dec 20, 2021

View reviewed changes

bsp/nuvoton/nk-n9h30/applications/lvgl/port/lv_demo.c Outdated Show resolved Hide resolved

bsp/nuvoton/nk-n9h30/applications/lvgl/port/lv_demo.c Outdated Show resolved Hide resolved

ttnwosay added 2 commits December 20, 2021 11:40

Updated about suggestions.

a1d9f1f

Large reserved partition size.

c339bc8

To avoid to overwrite larger firmware size with LVGL.

mysterywolf added the in progress PR/issue in progress. label Dec 20, 2021

Migrate lv porting folder.

1627c68

mysterywolf removed the in progress PR/issue in progress. label Dec 21, 2021

mysterywolf requested changes Dec 21, 2021

View reviewed changes

bsp/nuvoton/nk-n9h30/applications/lvgl/lv_conf.h Outdated Show resolved Hide resolved

bsp/nuvoton/nk-980iot/applications/lvgl/lv_conf.h Outdated Show resolved Hide resolved

mysterywolf added the in progress PR/issue in progress. label Dec 22, 2021

Guozhanxin mentioned this pull request Dec 24, 2021

v4.1.0 特性征集与讨论 | v4.1.0 discussion #5342

Closed

24 tasks

ttnwosay added 2 commits December 28, 2021 13:37

Update LVGLv81 porting.

b1442b4

1. Add RTGRAPHIC_CTRL_PAN_DISPLAY and RTGRAPHIC_CTRL_WAIT_VSYNC control command. 2. Add calibration data of 480x272 ADC touching. 3. Add 480x272 LCD panel menu option and driver. 4. Update lv_conf.h.

Correct coding-style format.

5e2d448

mysterywolf removed the in progress PR/issue in progress. label Dec 28, 2021

mysterywolf approved these changes Dec 28, 2021

View reviewed changes

mysterywolf added the +1 Agree +1 label Dec 28, 2021

mysterywolf requested a review from Guozhanxin December 28, 2021 09:03

mysterywolf closed this Dec 28, 2021

mysterywolf reopened this Dec 28, 2021

BernardXiong merged commit 8ab54c3 into RT-Thread:master Dec 29, 2021

wosayttn deleted the 20211217_LVGLv81 branch December 30, 2021 06:10

[nuvoton] Upgrade LVGL to v81 #5399

[nuvoton] Upgrade LVGL to v81 #5399

Uh oh!

Conversation

wosayttn commented Dec 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

拉取/合并请求描述：(PR description)

当前拉取/合并请求的状态 Intent for your PR

代码质量 Code Quality：

Uh oh!

Uh oh!

mysterywolf Dec 17, 2021

Choose a reason for hiding this comment

Uh oh!

wosayttn Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

wosayttn Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

mysterywolf Dec 20, 2021

Choose a reason for hiding this comment

Uh oh!

wosayttn Dec 21, 2021

Choose a reason for hiding this comment

Uh oh!

wosayttn Dec 28, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wosayttn commented Dec 17, 2021

Uh oh!

mysterywolf commented Dec 17, 2021

Uh oh!

Uh oh!

Uh oh!

mysterywolf commented Dec 20, 2021

Uh oh!

mysterywolf commented Dec 21, 2021

Uh oh!

Uh oh!

Uh oh!

mysterywolf commented Dec 28, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wosayttn commented Dec 28, 2021

Uh oh!

mysterywolf commented Dec 28, 2021

Uh oh!

mysterywolf commented Dec 28, 2021

Uh oh!

wosayttn commented Dec 30, 2021

Uh oh!

Uh oh!

wosayttn commented Dec 17, 2021 •

edited

Loading

mysterywolf commented Dec 28, 2021 •

edited

Loading