[bsp/gd32] add GD32VW55x BSP #11050
[bsp/gd32] add GD32VW55x BSP #11050
Conversation
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
📌 Code Review Assignment🏷️ Tag: workflowReviewers: Rbb666 kurisaW supperthomas Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-15 14:56 CST)
📝 Review Instructions
|
github-actions
bot
added
BSP
action
There was a problem hiding this comment.
Pull request overview
This PR adds board support package (BSP) for the GD32VW55x series MCU, specifically implementing support for the gd32vw553h-eval development board. The implementation is based on the existing gd32vf103 BSP template and has been verified on the target hardware.
Key changes:
- Added complete BSP implementation for GD32VW553H-EVAL board
- Updated shared driver files to support both GD32VF103V and GD32VW55x series
- Added CI compilation check for the new BSP
Reviewed changes
Copilot reviewed 22 out of 25 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/gd32/risc-v/libraries/gd32_drivers/drv_usart.c | Updated UART driver with GPIO configuration for GD32VW55x, changed comment style, updated copyright year |
| bsp/gd32/risc-v/libraries/gd32_drivers/drv_usart.h | Changed comment style from C++ to C style, updated copyright year |
| bsp/gd32/risc-v/libraries/gd32_drivers/drv_gpio.c | Added conditional compilation for GD32VW55x GPIO modes and configurations |
| bsp/gd32/risc-v/libraries/gd32_drivers/drv_gpio.h | Added GD32VW55x series support with conditional includes and pin definitions |
| bsp/gd32/risc-v/libraries/Kconfig | Added configuration for SOC_GD32VW553H |
| bsp/gd32/risc-v/gd32vw553h-eval/* | New BSP files including board initialization, configuration, documentation, and build scripts |
| .github/ALL_BSP_COMPILE.json | Added gd32vw553h-eval to CI compilation list |
| rt_uint32_t pin_otype = GPIO_OTYPE_PP; | ||
| rt_uint32_t pin_speed = GPIO_OSPEED_25MHZ; | ||
| #else | ||
| #error "not support soc" |
There was a problem hiding this comment.
The error message should be more descriptive and grammatically correct. Consider changing to 'Unsupported SOC series' or 'SOC series not supported'.
| #error "not support soc" | |
| #error "Unsupported SOC series" |
| #elif defined(SOC_SERIES_GD32VW55x) | ||
| pin_mode = GPIO_MODE_OUTPUT; | ||
| #else | ||
| #error "not support soc" |
There was a problem hiding this comment.
The error message should be more descriptive and grammatically correct. Consider changing to 'Unsupported SOC series' or 'SOC series not supported'.
| #elif defined(SOC_SERIES_GD32VW55x) | ||
| pin_otype = GPIO_OTYPE_OD; | ||
| #else | ||
| #error "not support soc" |
There was a problem hiding this comment.
The error message should be more descriptive and grammatically correct. Consider changing to 'Unsupported SOC series' or 'SOC series not supported'.
| #elif defined(SOC_SERIES_GD32VW55x) | ||
| pin_mode = GPIO_MODE_INPUT; | ||
| #else | ||
| #error "not support soc" |
There was a problem hiding this comment.
The error message should be more descriptive and grammatically correct. Consider changing to 'Unsupported SOC series' or 'SOC series not supported'.
| pin_mode = GPIO_MODE_INPUT; | ||
| pin_pull_up_down = GPIO_PUPD_PULLUP; | ||
| #else | ||
| #error "not support soc" |
There was a problem hiding this comment.
The error message should be more descriptive and grammatically correct. Consider changing to 'Unsupported SOC series' or 'SOC series not supported'.
| pin_mode = GPIO_MODE_INPUT; | ||
| pin_pull_up_down = GPIO_PUPD_PULLDOWN; | ||
| #else | ||
| #error "not support soc" |
There was a problem hiding this comment.
The error message should be more descriptive and grammatically correct. Consider changing to 'Unsupported SOC series' or 'SOC series not supported'.
| gpio_mode_set(index->gpio_periph, pin_mode, pin_pull_up_down, index->pin); | ||
| gpio_output_options_set(index->gpio_periph, pin_otype, pin_speed, index->pin); | ||
| #else | ||
| #error "not support soc" |
There was a problem hiding this comment.
The error message should be more descriptive and grammatically correct. Consider changing to 'Unsupported SOC series' or 'SOC series not supported'.
3 participants
拉取/合并请求描述：(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
gd32/risc-v/gd32vw553h-eval
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up