improved testing #10
Merged
improved testing #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhensle
approved these changes
Nov 12, 2025
dhensle
added a commit
that referenced
this pull request
Dec 5, 2025
…ss (ActivitySim#1005) * single process run with * ensured schedule order when generating alternatives * trip scheduling choice test fix * scheduling choice fix with linting * trip departture choice test fix * deleted extra outputs folder * restoring deleted arc test files * deleting extra added files * more file cleanup * removing arc from CI test list * improved testing (#10) * improved testing * blacken * stable sorting * blacken * addressing review comments --------- Co-authored-by: juangacosta <[email protected]> Co-authored-by: Jeffrey Newman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rewrote
test_run_trip_scheduling_choiceto test the model component without needing all the config file baggage.This pull request refactors the trip scheduling choice test in the ActivitySim ABM test suite to simplify configuration management and improve test clarity. The most significant changes are the removal of the external YAML settings file, inlining of model settings within the test, and enhancement of test assertions for output validation.
Configuration management improvements:
trip_scheduling_choice.yamlconfiguration file and inlined its relevant settings directly into the test code, eliminating external file dependency for model settings.settingsfixture and updated theskimsfixture to no longer depend on it, further simplifying test setup. [1] [2]Test logic and validation enhancements:
test_run_trip_scheduling_choice) to create a temporary workflow state and set model settings programmatically, clarifying the distinction between test and production model configuration.