Skip to content

Conversation

@sanyalington
Copy link

@sanyalington sanyalington commented Aug 13, 2024

Enable BF16 support in custom PA. Unit tests are in tests/kernels/test_attention.py.
All unit tests and e2e tests pass.
Also enabled custom PA support for head_size=64 and block_size=32.

HaiShaw
HaiShaw previously approved these changes Aug 14, 2024
Copy link

@HaiShaw HaiShaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fine work!
Just few comments.

@sanyalington sanyalington merged commit d5bf9bc into main Aug 14, 2024
@gshtras gshtras deleted the shsanyal_dev_PA branch August 15, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants