[flang][OpenMP] Further handling of target ... do fixup logic
#115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning `hlfir.declare` ops during fix up can result in type mismatches. For example, a `fir.ref<fir.array<...>>` variable is mapped a s `fir.box<fir.array<...>>` which results in the fix up logic creating invalid IR. This PR fixes the issue by avoiding cloning `hlfir.declare` ops in the first place since they are specially handled during the fix-up process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloning
hlfir.declareops during fix up can result in type mismatches. For example, afir.ref<fir.array<...>>variable is mapped a sfir.box<fir.array<...>>which results in the fix up logic creating invalid IR. This PR fixes the issue by avoiding cloninghlfir.declareops in the first place since they are specially handled during the fix-up process.