[CK_BUILDER] Add describe() method to device ops for runtime introspection #3375
+567
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shumway
requested review from
ThomasNing,
afagaj,
andriy-ca,
aosewski,
asleepzzz,
bartekxk,
carlushuang,
cgmillette,
coderfeli,
geyyer,
illsilin,
poyenc,
qianfengz,
tenpercent and
vidyasagar-amd
as code owners
shumway
force-pushed
the
jshumway/describe
branch
2 times, most recently
from
ee2ae70 to
6dad7fc
Compare
Introduces a polymorphic describe() method to BaseOperator that enables runtime introspection of kernel configurations through a unified interface. Key changes: - Add virtual describe() method to BaseOperator returning Description objects - Implement describe() in 6 device operation classes (conv fwd/bwd variants) - Create conv_describe.hpp with factory function for ConvDescription - Extract type definitions to conv_types.hpp to resolve circular dependencies - Add InstanceStringDescription for kernels without full ConvDescription support Improvements: - Add ODD_C to ConvFwdSpecialization enum and fix OddC mapping - Add missing types and missing elementwise ops - Add missing layouts to conv_trits.hpp - Replace silent fallbacks in conv_traits.hpp to compile-time errors - Remove circular dependency include from conv_traits.hpp - Update tests to use describe() instead of GetInstanceString() TODO: The enums for types and elementwise ops should be simplified with a better design, but that's out of scope for this PR. This provides a foundation for runtime kernel introspection and better tooling support for analyzing and debugging kernel configurations.
shumway
force-pushed
the
jshumway/describe
branch
from
6dad7fc to
13fa245
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a polymorphic describe() method to BaseOperator that enables runtime introspection of kernel configurations through a unified interface.
Key changes:
Other Improvements:
This provides a foundation for runtime kernel introspection and better tooling support for analyzing and debugging kernel configurations.