Skip to content

ODC-188 drop legacy GatingSetList from openCyto test suite. #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
djhammill wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

ODC-188 drop legacy GatingSetList from openCyto test suite. #266

djhammill wants to merge 2 commits into from

Conversation

@djhammill
Copy link
Contributor

@djhammill djhammill commented Nov 6, 2024

@amcdavid this is a very minor change to remove the legacy GatingSetList constructor from the openCyto test suite.

@djhammill djhammill requested a review from amcdavid November 6, 2024 03:33
@djhammill djhammill self-assigned this Nov 6, 2024
@djhammill
Copy link
Contributor Author

djhammill commented Nov 6, 2024 •
edited
Loading

There are a few more warnings in the test suite but they are all coming from flowCore:::.flowParamMatch() - I am looking into that now.

@djhammill
Copy link
Contributor Author

djhammill commented Nov 6, 2024

There was one lingering call to getChannelMarker() where multiple channels are passed by openCyto but only a single channel is expected by getCHannelMarker(). I have added a fix for that too - with this PR I no longer see any warnings in test suite except for the occasional flowClust convergence warning in test-misc.R.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amcdavid amcdavid Awaiting requested review from amcdavid

Assignees

@djhammill djhammill

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@djhammill