Skip to content

Conversation

@renkun-ken
Copy link
Member

@renkun-ken renkun-ken commented Nov 4, 2021

What problem did you solve?

Closes #855

This PR fixes the detection of yaml frontmatter in rmd. It only tries to capture the first yaml chunk surrounded by --- at the top of the document.

(If you do not have screenshot) How can I check this pull request?

Knit the following document should use bookdown::render_book instead of rmarkdown::render.

---
output: bookdown::gitbook
knit: bookdown::render_book
---

# Test

Para.

---

# Next

@ElianHugh
Copy link
Collaborator

ElianHugh commented Nov 5, 2021

LGTM, didn't run into any errors. Thanks!

(Not sure why the docker build failed)

@renkun-ken renkun-ken merged commit 290caa3 into REditorSupport:master Nov 8, 2021
ElianHugh pushed a commit to ElianHugh/vscode-R that referenced this pull request May 12, 2022
* Fix detecting yaml frontmatter

* Simplify condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Smart custom knit doesn't work when --- separator exists in Rmd

2 participants