Use new terminal API #851
Merged
Use new terminal API #851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a terminal profile for R using the API discussed e.g. in microsoft/vscode#120369.
The existing "Create R Terminal" command is not affected. Creating a terminal using the terminal profile should behave the same as using the command.
The API to add a custom icon for the terminal profile is still being discussed (microsoft/vscode#127607), so I just left the default icon for now.
To test:
Call the command
Terminal: Create new terminal (with profile)and selectR Terminalor use the dropdown next to the new terminal button.