Completely replace View()
#818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renkun-ken
commented
Oct 10, 2021
| .vsc.page_viewer <- .vsc$show_page_viewer | ||
|
|
||
| # assign functions that are optional: | ||
| for (funcName in c("View")) { |
Member
Author
There was a problem hiding this comment.
funcName is actually leaked to be a global variable in the current release.
ManuelHentschel
approved these changes
Oct 11, 2021
Member
ManuelHentschel
left a comment
ManuelHentschel
left a comment
There was a problem hiding this comment.
Lgtm, thanks!
Side note: On my machine the viewer only works when webpack is enabled, otherwise it just opens an empty webview.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes randy3k/radian#316.
This PR completely replaces
View()andutils::View()in favor of the session watcher version so thattibble::viewalso opens a data viewer in vscode.(If you do not have screenshot) How can I check this pull request?
The following should all open a data viewer in vscode: